-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(terminal): correctly forward mouse events #16373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeertzjq
force-pushed
the
terminal-mouse-release-forward
branch
2 times, most recently
from
November 20, 2021 09:49
ffd0054
to
796a864
Compare
Tests fail if I revert the change:
|
zeertzjq
force-pushed
the
terminal-mouse-release-forward
branch
2 times, most recently
from
November 20, 2021 11:21
cc575e6
to
95e928b
Compare
erw7
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked terminal.c
of vim and found the same process, so I think this change is fine.
@zeertzjq LGTM, rebase? |
zeertzjq
force-pushed
the
terminal-mouse-release-forward
branch
2 times, most recently
from
December 26, 2021 21:29
1d0f4c7
to
0d44448
Compare
Hmm, CI seems to be encountering some Internet problems. |
zeertzjq
force-pushed
the
terminal-mouse-release-forward
branch
2 times, most recently
from
December 26, 2021 21:59
56bc518
to
9439928
Compare
zeertzjq
force-pushed
the
terminal-mouse-release-forward
branch
from
December 26, 2021 22:08
9439928
to
e0956f7
Compare
Oh, CI passed. |
Would be nice to have a build with this fix 😇 |
ping @bfredl |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16371.