Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Replace deprecated guzzle functions with static methods #3368

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

albe
Copy link
Member

@albe albe commented Jul 1, 2021

See guzzle/psr7#345

Related to neos/flow-development-collection#2455 - hence why this targets 7.1 instead of master

@albe albe added the dependencies Pull requests that update a dependency file label Jul 1, 2021
@albe
Copy link
Member Author

albe commented Jul 1, 2021

TODO: Find other potential usages

See https://github.com/neos/neos-development-collection/search?q=GuzzleHttp

mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Jul 1, 2021
@mhsdesign
Copy link
Member

TODO: Find other potential usages

found 2 ;) #3369

@albe
Copy link
Member Author

albe commented Jul 2, 2021

  1. Neos\ContentRepository\Tests\Unit\Domain\Service\NodeServiceTest::createChildNodesTryToCreateAllConfiguredChildNodes
    PHPUnit\Framework\MockObject\ClassIsFinalException: Class "Neos\ContentRepository\Domain\NodeAggregate\NodeAggregateIdentifier" is declared "final" and cannot be mocked

🤨

Edit: Ok, that is apparently a bug in testing that was introduced with the upmerge here https://github.com/neos/neos-development-collection/runs/2485993159?check_suite_focus=true / 9dae1a8

So safely unrelated to this.

@daniellienert daniellienert merged commit 4531610 into 7.1 Jul 15, 2021
@daniellienert daniellienert deleted the guzzle-deprecations branch July 15, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants