TASK: Require all collection packages as self.version
#3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlemke
approved these changes
May 9, 2023
kitsunet
approved these changes
May 11, 2023
ahaeslich
reviewed
Jul 25, 2023
Comment on lines
+17
to
+28
| "neos/cache": "self.version", | ||
| "neos/eel": "self.version", | ||
| "neos/error-messages": "self.version", | ||
| "neos/utility-arrays": "self.version", | ||
| "neos/utility-files": "self.version", | ||
| "neos/utility-mediatypes": "self.version", | ||
| "neos/utility-objecthandling": "self.version", | ||
| "neos/utility-opcodecache": "self.version", | ||
| "neos/utility-schema": "self.version", | ||
| "neos/utility-unicode": "self.version", | ||
| "neos/flow-log": "self.version", | ||
| "neos/http-factories": "self.version", |
There was a problem hiding this comment.
This change was lost with the release on 29.06: ee09e21. @kdambekalns did you expect this to be changed during releases?
There was a problem hiding this comment.
No, didn't expect that… 😥
There was a problem hiding this comment.
Ah, the release scripts… I did not think of those. 🤦♂️
This was referenced Sep 28, 2023
kdambekalns
added a commit
to kdambekalns/flow-development-collection
that referenced
this pull request
Oct 31, 2023
See neos#3035 for the original change
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any dependency from one package in the collection to another should always be "to the same version".
This changes makes sure this is the case by using
self.versionas the required version.See #3034
Checklist
Code follows the PSR-2 coding styleTests have been created, run and adjusted as neededFEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked wit!!!and have upgrade-instructions