New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! FEATURE: Raise phpunit to v8.1 #1565
Conversation
For Unit-Tests i'm down to this:
Some warnings are left regarding sebastianbergmann/phpunit#3338.
|
To make travis run with phpunit 8.1 we need this one merged |
Open tasks Unit-Tests:
Open tasks Functional-Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests are working
This change raises the phpunit requirement to v8.1. This might be breaking for you as phpunit introduced return types on methods like
public setUp(): void
as well aspublic tearDown(): void
. PHPUnit also deprecated a lot of methods. You might find here some more background information about replacements for your assertions.Resolves #1506