Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: don't call get_vectored with empty keyspace #7686

Merged
merged 1 commit into from
May 10, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented May 9, 2024

Problem

This caused a variation of the stats bug fixed by #7662. That PR also fixed this case, but we still shouldn't make redundant get calls.

Summary of changes

  • Only call get in the create image layers loop at the end of a range if some keys have been accumulated

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels May 9, 2024
@jcsp jcsp requested a review from a team as a code owner May 9, 2024 18:29
@jcsp jcsp requested a review from petuhovskiy May 9, 2024 18:29
Copy link

github-actions bot commented May 9, 2024

3048 tests run: 2915 passed, 0 failed, 133 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_lock_time_tracing: release
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_physical_replication: release

Postgres 14

  • test_gc_aggressive: debug
  • test_location_conf_churn[1]: release

Code coverage* (full report)

  • functions: 31.4% (6320 of 20132 functions)
  • lines: 47.3% (47622 of 100707 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
19b679f at 2024-05-10T11:09:33.407Z :recycle:

@jcsp jcsp enabled auto-merge (squash) May 10, 2024 10:49
@jcsp jcsp merged commit 13d9589 into main May 10, 2024
55 of 56 checks passed
@jcsp jcsp deleted the jcsp/empty-range-get branch May 10, 2024 11:01
a-masterov pushed a commit that referenced this pull request May 20, 2024
## Problem

This caused a variation of the stats bug fixed by
#7662. That PR also fixed this
case, but we still shouldn't make redundant get calls.

## Summary of changes

- Only call get in the create image layers loop at the end of a range if
some keys have been accumulated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants