Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remote_storage: AWS_PROFILE with endpoint overrides in ~/.aws/config …
…(updates AWS SDKs) (#7664) Before this PR, using the AWS SDK profile feature for running against minio didn't work because * our SDK versions were too old and didn't include awslabs/aws-sdk-rust#1060 and * we didn't massage the s3 client config builder correctly. This PR * udpates all the AWS SDKs we use to, respectively, the latest version I could find on crates.io (Is there a better process?) * changes the way remote_storage constructs the S3 client, and * documents how to run the test suite against real S3 & local minio. Regarding the changes to `remote_storage`: if one reads the SDK docs, it is clear that the recommended way is to use `aws_config::from_env`, then customize. What we were doing instead is to use the `aws_sdk_s3` builder directly. To get the `local-minio` in the added docs working, I needed to update both the SDKs and make the changes to the `remote_storage`. See the commit history in this PR for details. Refs: * byproduct: smithy-lang/smithy-rs#3633 * follow-up on deprecation: #7665 * follow-up for scrubber S3 setup: #7667
- Loading branch information
ab10523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3105 tests run: 2957 passed, 2 failed, 146 skipped (full report)
Failures on Postgres 14
test_storage_controller_many_tenants[github-actions-selfhosted]
: releasetest_bulk_tenant_create[github-actions-selfhosted-5]
: releaseFlaky tests (3)
Postgres 16
test_vm_bit_clear_on_heap_lock
: releasePostgres 15
test_statvfs_pressure_usage
: debugPostgres 14
test_partial_evict_tenant[relative_equal]
: releaseCode coverage* (full report)
functions
:31.4% (6315 of 20126 functions)
lines
:47.3% (47594 of 100686 lines)
* collected from Rust tests only
ab10523 at 2024-05-09T10:37:09.093Z :recycle: