Addition of GDS client to the Docs dropdown menu in the header #225
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @lidiazuin - I think the dropdown is also missing the new Query API, could we add it in this PR? |
src/partials/navbar-end.hbs
Outdated
| @@ -93,6 +93,7 @@ | |||
| <span class="project-name">Neo4j Graph Data Science</span> | |||
| <ul class="project-links"> | |||
| <li><a href="/docs/graph-data-science/current/" class="project-link">Neo4j Graph Data Science Library</a></li> | |||
| <li><a href="/docs/graph-data-science-client/current/" class="project-link">Neo4j Graph Data Science Client</a></li> | |||
There was a problem hiding this comment.
Indent this as the previous <li> element.
.github/workflows/release.yml
Outdated
| @@ -36,4 +36,4 @@ jobs: | |||
|
|
|||
| - name: Sync UI Bundle to S3 | |||
| run: | | |||
| aws s3 sync --follow-symlinks --include '*.zip' --no-progress build s3://${{ secrets.STATIC_CONTENT_BUCKET }}/build | |||
| aws s3 sync --follow-symlinks --include '*.zip' --no-progress build s3://${{ secrets.STATIC_CONTENT_BUCKET }}/build | |||
There was a problem hiding this comment.
Remove changes to both workflow files from this PR, as they don't belong. It's good hygiene and will help any future troubleshooting involving those files.
src/partials/navbar-end.hbs
Outdated
| <li><a href="/docs/ogm-manual/current/" class="project-link">OGM Library</a></li> | ||
| <li><a href="https://docs.spring.io/spring-data/neo4j/docs/current/reference/html/#reference" class="project-link">Spring Data Neo4j</a></li> | ||
| <li><a href="/docs/http-api/current/" class="project-link">HTTP API</a></li> | ||
| <li><a href="/docs/query-api" class="project-link">Neo4j Query API</a></li> |
There was a problem hiding this comment.
All versioned docsets should have links pointing to /current, to avoid a redirect. It applies to Query API and Dataflow templates, but there may be more to fix in this file.
No description provided.