-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New home and hub initial #223
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
. *Working with data sets* | ||
+ | ||
Learn stuff | ||
. *Step 3 goes here* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: with these changes, now every time we use .
it will turn into the blue circled number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's using a role that is applied to the whole list, in this case [.next-steps]
, so only lists with that role would have the styles applied.
Also, the css styles for this role are only applied when the page-layout
attribute is set to docs-ndl
, which we will use for all the new index pages. If we want to use this style of list anywhere else we could remove that requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I missed the [.next-steps]
line. I was wondering if that could be helpful for tutorial pages at some point, but we can revisit that later. Thanks for explaining!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this could become a reusable pattern that we can apply to existing docs - tutorials are a good example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing the feedback widget. I guess we can use the same style, just update with NDL colors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've restored the feedback widget - it disabled it at some point in the pages while developing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add rounded corners to embedded videos? I found this code to be added in the custom CSS:
.video-player .plyr video { object-fit: cover !important; border-radius: 10px !important; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a border-radius
to display slightly rounded corners
No description provided.