Add 'all' option and display labels if selected #172
+1,472
−662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidoliverSP2
approved these changes
May 22, 2023
There was a problem hiding this comment.
I think it is useful to add an "All" option, even though this is going to be exactly the same as "Neo4j Enterprise Edition"? (maybe it won't always match EE though, which future proofs any decisions that come down the pipeline)
Just an observation - if you select All in the built page, the link doesn't work - was that expected?
|
It wasn't expected as such, but the logic of whether or not it tries to update the URL could be improved. |
When an ID is set on a block that is part of a tabbed group the tab switching and scroll happens as it does when a user clicks on a tab.
``` :page-banner: note :page-banner-text: Lorem ipsum dolor sit est. :page-banner-link: https://neo4j.com/docs :page-banner-link-text: Link text ``` `note` is the default, `warning` can also be used.
Usage `[role=label--*]` Can be existing labels eg `[role=label--enterprise-edition]` or action-version labels such as `[role=label--new-5.11]` or `[role=label--deprecated-5.13]` - Roles are converted to labels. - Roles applied to headings and table captions are displayed inline, right-aligned. - Roles on block level elements are displayed before the corresponding block element.
Fixes a few issues in the initial implementation of neo4j-documentation#211: - adds `cluster` and `dynamic` labels - fixes padding in admonitions
…pher query parameters.
…ation#226) I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the addition of an
alloption in the products dropdown.allis selectedlocalhostis the url.hostallis selected