Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw when invalid
uses
key is provided #1804throw when invalid
uses
key is provided #1804Changes from 10 commits
e874540
79776a8
ab711ff
5a95bfe
b8b3c8e
0060436
919982c
7d005c1
921167b
bc33613
fb5febc
f678692
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 62 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L61-L62
Check warning on line 88 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L87-L88
Check warning on line 94 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L93-L94
Check warning on line 124 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L123-L124
Check warning on line 129 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L128-L129
Check warning on line 135 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L134-L135
Check warning on line 219 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L218-L219
Check warning on line 232 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L231-L232
Check warning on line 245 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L245
Check warning on line 250 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L250
Check warning on line 262 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L261-L262
Check warning on line 268 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L267-L268
Check warning on line 281 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L280-L281
Check warning on line 287 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L286-L287
Check warning on line 298 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L297-L298
Check warning on line 314 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L314
Check warning on line 376 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L376
Check warning on line 681 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L680-L681
Check warning on line 689 in pkg/model/workflow.go
Codecov / codecov/patch
pkg/model/workflow.go#L686-L689
Check warning on line 103 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L92-L103
Check warning on line 326 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L322-L326
Check warning on line 340 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L339-L340
Check warning on line 393 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L392-L393
Check warning on line 466 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L465-L466
Check warning on line 535 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L535
Check warning on line 539 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L539
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops the
else if jobType != model.JobTypeDefault {
block needs to be moved back, because it should allow skipping reusable workflows.While jobtypeinvalid should return an error as early as possible.
This means we don't have a test for skipping reusable workflows
Check warning on line 699 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L698-L699
Check warning on line 702 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L701-L702
Check warning on line 704 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L704
Check warning on line 810 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L810
Check warning on line 95 in pkg/runner/runner.go
Codecov / codecov/patch
pkg/runner/runner.go#L94-L95
Check warning on line 123 in pkg/runner/runner.go
Codecov / codecov/patch
pkg/runner/runner.go#L123
Check warning on line 154 in pkg/runner/runner.go
Codecov / codecov/patch
pkg/runner/runner.go#L153-L154