Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ranked choice signups (wip) #8040

Draft
wants to merge 54 commits into
base: main
Choose a base branch
from
Draft

Ranked choice signups (wip) #8040

wants to merge 54 commits into from

Conversation

nbudin
Copy link
Contributor

@nbudin nbudin commented Jul 29, 2023 •
edited

TODO:

  • Figure out how to separate ranked choices from moderated signups that are actually in the queue

@nbudin nbudin force-pushed the option-2 branch 2 times, most recently from 1391664 to df7738d Compare April 27, 2024 17:30
nbudin added 25 commits May 19, 2024 16:12
@nbudin
wip
34a6264
@nbudin
Generate lottery numbers for user con profiles
89120cc
@nbudin
Implement a service for signing up users
3d7caf4
@nbudin
Fix regression
e3a0841
@nbudin
happy path bug fixes
a8a833d
@nbudin
Signup buttons UI changes (wip)
f7fbf91
@nbudin
wip
53092c8
@nbudin
Fix typo
ec097c9
@nbudin
Make SignupRankedChoice a separate thing from SignupRequest
c3fed44
@nbudin
wip
838ead9
@nbudin
Allow ranked choices to be accepted as requests
f7de542
@nbudin
Don't break moderated-signup cons when ranked choices are done
302a131
@nbudin
Show next round info in UI
101a057
@nbudin
Update Yarn sdks
a31441b
@nbudin
wip
14f4ecd
@nbudin
Refactoring, tests, bug fixes
5329e84
@nbudin
Upgrade Bundler
a86e4bf
@nbudin
Handle waitlisting properly in moderated signup cons
bba0efd
@nbudin
Delete ranked choices
1ded0ff
@nbudin
Priority adjustment and deletion
76f03c5
@nbudin
Make SignupRound a model
91dfc04
@nbudin
Fix up rubocop config
44de23b
@nbudin
Moar cop fixes
5396e4f
@nbudin
Tell ReviewDog about new rubocop plugins
d30fabe
@nbudin
Tell ReviewDog about Prism
62a309e
nbudin added 22 commits May 19, 2024 16:12
@nbudin
Make wrapper service execute against a SignupRound
678328e
@nbudin
Add tests + allow_waitlist flag
90b89c8
@nbudin
Add code coverage reporting for Ruby
0365ad4
@nbudin
Keep rounds going until all signups are done
87f73ad
@nbudin
More robust test for the complex round
e32023f
@nbudin
Fix type errors
db8f54e
@nbudin
Fix tests
b032b9a
@nbudin
Try a maybe-better coverage bot
db7838a
@nbudin
Automatically execute rounds when they're due
5a3aac2
@nbudin
Fix some of the rubocop warnings
d2990f2
@nbudin
Let rubocop-graphql do its thing and see what reviewdog does
597095c
@nbudin
Document many things
517d2ee
@nbudin
Moar schema docs
33234d9
@nbudin
Autogenerate descriptions for root mutation fields
150f20e
@nbudin
Document SignupRequest
2835c82
@nbudin
Give the state enums descriptions
1add0ec
@nbudin
Document remaining fields in Convention; deprecate maximum_event_signups
6973e44
@nbudin
Document ConventionInput
eaf90d2
@nbudin
Document SignupAutomationMode
352bc3c
@nbudin
Disable manual signups while running
5181585
@nbudin
Backend support for user-set maximum signup constraints
fe9cb8d
@nbudin
First crack at a settings UI design (not yet working)
ebfadc1
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Code Coverage Report

Package Coverage
intercode 🟢 85%
Overall Coverage 🟢 85%

Minimum allowed coverage is 0%, this run produced 85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nbudin