Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ca_pubkey in cloning sensemaker #11

Merged
merged 5 commits into from
Feb 1, 2023
Merged

use ca_pubkey in cloning sensemaker #11

merged 5 commits into from
Feb 1, 2023

Conversation

weswalla
Copy link
Collaborator

@weswalla weswalla commented Jan 31, 2023

closes #10

@weswalla weswalla changed the title Create or join nh use ca_pubkey in cloning sensemaker Jan 31, 2023
@pospi
Copy link
Collaborator

pospi commented Jan 31, 2023

This runs fine for me so looks good to merge.

However! I think I'll hold off integrating it into my own work yet for two reasons:

  • determine role of WDS in development pipeline #9 no WDS means no HMR, and having to click this button each time one makes a change to get back to the first app window is another barrier to rapid development
  • my Tauri window is still showing the expected DOM but not rendering any visuals, and I need to figure this out before interacting with the NH creation UI.

@pospi pospi self-requested a review January 31, 2023 09:06
@weswalla
Copy link
Collaborator Author

weswalla commented Feb 1, 2023

#9 no WDS means no HMR, and having to click this button each time one makes a change to get back to the first app window is another barrier to rapid development

@pospi you shouldn't have to click the button every time you make a change, as it checks if the sensemaker has been cloned, and only if it hasn't yet been cloned will the page with buttons show up

@weswalla weswalla merged commit 01e7522 into main Feb 1, 2023
@weswalla weswalla deleted the create-or-join-nh branch February 1, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure multiple agent join the same sensemaker network
2 participants