annotate: annotate missing branches with "~" #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blueyed Thanks for persisting with this. I've never valued the annotation feature. Do you use it? |
nedbat
changed the title
nedbat
reviewed
Jun 30, 2018
| @@ -0,0 +1,36 @@ | |||
| # Licensed under the Apache License: http://www.apache.org/licenses/LICENSE-2.0 | |||
| # For details: https://bitbucket.org/ned/coveragepy/src/default/NOTICE.txt | |||
There was a problem hiding this comment.
You'll need to correct the NOTICE links to GitHub to get the tests to pass.
nedbat
reviewed
Jun 30, 2018
| @@ -60,6 +60,7 @@ def annotate_file(self, fr, analysis): | |||
| statements = sorted(analysis.statements) | |||
| missing = sorted(analysis.missing) | |||
| excluded = sorted(analysis.excluded) | |||
| missing_branches = sorted(analysis.missing_branch_arcs().keys()) | |||
There was a problem hiding this comment.
There's no reason to sort this, since we're just using in on it. Making it a set would be better. Same for excluded, though that was my fault! :) statements and missing need to be sorted because of how the algorithm walks them in tandem.
Yes, but mostly for debugging/developing. I've just created #677 - where this is included already (without the tests). |
nedbat
force-pushed
the
master
branch
2 times, most recently
from
0c14f1a
to
82169a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.