Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force / in actual_path() on Windows #1409

Closed
wants to merge 5 commits into from

Conversation

altendky
Copy link

@altendky altendky commented Jun 20, 2022

This is intended to make relative paths generated on Windows usable in Linux and macOS.

#991

Draft for:

  • Tests
  • Discussion around better solutions or other places that should be addressed.

@altendky
Copy link
Author

So this trivial change ran ok in my single test usage at https://github.com/Chia-Network/chia-blockchain/runs/6972851503?check_suite_focus=true, but a bunch of tests fail here. I'll keep looking around and trying to get a better feel but if you have some design guidance in mind, what with you actually knowing the code base already :], I'm all ears. Or eyes, I suppose.

@nedbat
Copy link
Owner

nedbat commented Oct 15, 2022

I think this has been handled in commit 7df8609.

@nedbat nedbat closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants