Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid a race condition in misc.ensure_dir #1220

Merged
merged 1 commit into from Sep 2, 2021
Merged

fix: Avoid a race condition in misc.ensure_dir #1220

merged 1 commit into from Sep 2, 2021

Commits on Sep 2, 2021

  1. fix: Avoid a race condition in misc.ensure_dir 

    * coverage/misc.py (ensure_dir): Pass exist_ok to os.makedirs, ensuring that if
two concurrent instances of coverage.py entering this function at the same time
won't fail with FileExistsError.

Sample backtrace:

    Traceback (most recent call last):
      File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
        return _run_code(code, main_globals, None,
      File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
        exec(code, run_globals)
      File "/home/user/.local/lib/python3.8/site-packages/coverage/__main__.py", line 8, in <module>
        sys.exit(main())
      File "/home/user/.local/lib/python3.8/site-packages/coverage/cmdline.py", line 871, in main
        status = CoverageScript().command_line(argv)
      File "/home/user/.local/lib/python3.8/site-packages/coverage/cmdline.py", line 588, in command_line
        return self.do_run(options, args)
      File "/home/user/.local/lib/python3.8/site-packages/coverage/cmdline.py", line 743, in do_run
        self.coverage.start()
      File "/home/user/.local/lib/python3.8/site-packages/coverage/control.py", line 535, in start
        self._init_for_start()
      File "/home/user/.local/lib/python3.8/site-packages/coverage/control.py", line 474, in _init_for_start
        self._init_data(suffix)
      File "/home/user/.local/lib/python3.8/site-packages/coverage/control.py", line 512, in _init_data
        ensure_dir_for_file(self.config.data_file)
      File "/home/user/.local/lib/python3.8/site-packages/coverage/misc.py", line 165, in ensure_dir_for_file
        ensure_dir(os.path.dirname(path))
      File "/.local/lib/python3.8/site-packages/coverage/misc.py", line 160, in ensure_dir
        os.makedirs(directory)
      File "/usr/lib/python3.8/os.py", line 223, in makedirs
        mkdir(name, mode)
    @cpitclaudel
    cpitclaudel committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    96bafbc View commit details
    Browse the repository at this point in the history