[xmlreport] when a filepath is in multiple source dirs, choose the highest one #1146
Conversation
|
@alex Will #578 (comment) sill work with your update? |
|
Maybe! I'm not sure. I'm also now many yaks deep and mostly turned my attention towards: #1147 |
|
@alex 😁 nice! Well I put another pr for the docs. |
* updated docs for #578 recommendation #578 #578 (comment) https://bitbucket.org/suriya/coverage-xml-bug/pull-requests/1/demonstrate-a-fix-to-coverage-xml-bug/diff also see #1146 * fixed per lint * updated per lint
@christopherpickering Sorry for jumping in on this, but is this what is still needed to merge this PR? And if so, why is this not covered by the tests? |
|
@gro1m I'm not sure, that was a long time ago. |
@christopherpickering I understand that, on the other hand the change is small: the source_path is traversed bottom up from the filesystem tree, i.e. deepest level first to top-level and all tests are green. From that perspective, I do not really see what holds this back and I think to avoid ambiguity it would be really great to have the whole file path and not just the filename. So it would be great if someone could tell what is needed to merge this PR... |
|
nedbat
force-pushed
the
master
branch
2 times, most recently
from
0c14f1a
to
82169a6
Compare
|
Is this still valid? Seems like it passed almost all checks but is a bit old |
I think so, but I am not a contributor to the project. In the end, we could also fix the issue by using the workaround in #578 (comment). |
|
At this point, whatever the motivation for this is has long been overcome by events. |
fixes #578