if source looks like a package add it to source_pkgs #1030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Sep 4, 2020
|
I don't understand what the re.match is trying to determine. Can you write a few sentences (docs?) about what this change does? |
even if it's a dir too
graingert
force-pushed
the
add-source-to-pkgs-and-dir
branch
from
b9f6189
to
9f0bde7
Compare
graingert
commented
Sep 4, 2020
graingert
commented
Sep 4, 2020
| @@ -108,6 +110,14 @@ def module_has_file(mod): | |||
| return os.path.exists(mod__file__) | |||
|
|
|||
|
|
|||
| _IS_PKG_RE = re.compile( | |||
There was a problem hiding this comment.
on python3.8 _IS_PKG_RE is
re.compile(r"\A(((?!False|None|True|and|as|assert|async|await|break|class|continue|def|del|elif|else|except|finally|for|from|global|if|import|in|is|lambda|nonlocal|not|or|pass|raise|return|try|while|with|yield)\w+)\.?)+\Z")
There was a problem hiding this comment.
a bit like:
all(s.isidentifier() and not keyword.iskeyword(s) for s in v.split("."))
but s.isidentifier() is not on python2 and the RE is faster
There was a problem hiding this comment.
@nedbat something like this?
Suggested change
| _IS_PKG_RE = re.compile( | |
| # a dot delimited string of names that are not keywords | |
| _module_name_re = re.compile( |
|
This seems like too much guessing to me. And it would change the behavior of |
|
Yep, makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an alternative to #1026 in which ambiguous
sourcedefinitions use the package and the dir