-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Logs Table v1 #728
Conversation
frontend/src/components/Logs/LogsViewContainer/IndexerLogsContainer.tsx
Outdated
Show resolved
Hide resolved
All the Logs Table Logic begins by following the container file frontend/src/components/Logs/LogsViewContainer/IndexerLogsContainer.tsx here we defined a series of configs
The Logs Menu is on houses all the logic for the menu |
Lots of work to do but kicking off an initial review The files add/removed should be relatively simple. Fingers crossed for the reviewers. Only change required on my end is exporting DEV_ENV/PROD_ENV environment variables. There is a refactor of graphQL queries into dynamic queries using default variables that @morgsmccauley mentioned.
|
frontend/src/components/Logs/GraphQL/GetSearchLogsQueryDefinition.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/Logs/GraphQL/GetSearchLogsQueryDefinition.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/Logs/GraphQL/GetSearchLogsQueryDefinition.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/Logs/LogsViewContainer/DateSelectorContainer.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Logs/LogsViewContainer/IndexerLogsContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I like how you separated out the smaller view components 🙌🏼
}, | ||
body: JSON.stringify({ | ||
query: Query(tableName), | ||
variables: QueryValidation({ limit: LOGS_PER_PAGE, offset: 0, order_by_timestamp: 'desc', level: severity, type: logType, timestamp: startTime }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does offset
need to change based on page number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have any form of pagination currently. Each filter/added filter is its individual call. But yes it would have to change when we implement infinite scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work on it! The broken up files are much easier to ingest mentally.
Introduce an improved logs table with new fields and the ability to search and filter based of radio inputs.