fix(forknet): filter tracing and dumper nodes #11268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11268 +/- ##
==========================================
+ Coverage 70.99% 71.02% +0.02%
==========================================
Files 780 780
Lines 154984 154984
Branches 154984 154984
==========================================
+ Hits 110037 110073 +36
+ Misses 40204 40166 -38
- Partials 4743 4745 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
btw, I'm currently working on actually implementing the stuff that needs to get done to configure one of the nodes not to validate and to dump state parts, and I think it makes sense to go with a different approach than what this PR gives a skeleton for tbh |
VanBarbascu
force-pushed
the
forknet-select-hosts
branch
from
b80468c
to
6e7fb5a
Compare
|
We will go ahead with Marcelo's proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced 2 new nodes to the network. We don't want to pick them up as validator nodes.