Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stateless_validation] Missing main transition state proof for old block pytest repro #11188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Apr 30, 2024

A pytest not_validating.py reproduces the error: #10964.

Instructions to run the test

cargo build -p neard --features test_features,statelessnet_protocol
python3 pytest/tests/adversarial/not_validating.py

@staffik staffik changed the title Not validating [stateless_validation] Missing main transition state proof for old block pytest repro Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 71.10%. Comparing base (09b8b40) to head (7733214).
Report is 12 commits behind head on master.

Files Patch % Lines
chain/jsonrpc/src/lib.rs 0.00% 5 Missing and 1 partial ⚠️
chain/client/src/client_actions.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11188      +/-   ##
==========================================
+ Coverage   70.23%   71.10%   +0.86%     
==========================================
  Files         774      783       +9     
  Lines      154277   155401    +1124     
  Branches   154277   155401    +1124     
==========================================
+ Hits       108363   110504    +2141     
+ Misses      41566    40454    -1112     
- Partials     4348     4443      +95     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (+<0.01%) ⬆️
db-migration 0.24% <0.00%> (+<0.01%) ⬆️
genesis-check 1.41% <0.00%> (-0.01%) ⬇️
integration-tests 37.02% <28.57%> (+1.27%) ⬆️
linux 69.21% <50.00%> (+0.61%) ⬆️
linux-nightly 70.55% <28.57%> (+0.87%) ⬆️
macos 53.01% <50.00%> (-0.23%) ⬇️
pytests 1.63% <0.00%> (-0.02%) ⬇️
sanity-checks 1.42% <0.00%> (-0.01%) ⬇️
unittests 65.71% <14.28%> (-0.20%) ⬇️
upgradability 0.29% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant