Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stateless_validation] Remove old state witness distribution mechanism #11179

Merged
merged 5 commits into from May 24, 2024

Conversation

shreyan-gupta
Copy link
Contributor

This PR removes a bunch of things that were being used in the old way of distributing chunk state witness. Changes include

  • Rename ProcessChunkStateWitnessMessage to ChunkStateWitnessMessage
  • Remove verify_chunk_state_witness_signature in epoch manager
  • Remove process_signed_chunk_state_witness and partially_validate_state_witness in client
  • State witness actions doesn't use old mechanism for sending state witness
  • Remove ChunkStateWitness network message
  • Remove SignedEncodedChunkStateWitness

Note: Do not merge this till all nodes in forknet are deployed with the partial encoded state witness change

@shreyan-gupta shreyan-gupta added the A-stateless-validation Area: stateless validation label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.27%. Comparing base (66031e2) to head (5ec9065).

Files Patch % Lines
...nt/src/stateless_validation/chunk_validator/mod.rs 66.66% 0 Missing and 1 partial ⚠️
...alidation/partial_witness/partial_witness_actor.rs 0.00% 0 Missing and 1 partial ⚠️
chain/network/src/network_protocol/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11179      +/-   ##
==========================================
+ Coverage   71.24%   71.27%   +0.02%     
==========================================
  Files         784      784              
  Lines      157961   157847     -114     
  Branches   157961   157847     -114     
==========================================
- Hits       112539   112499      -40     
+ Misses      40567    40495      -72     
+ Partials     4855     4853       -2     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (+<0.01%) ⬆️
db-migration 0.24% <0.00%> (+<0.01%) ⬆️
genesis-check 1.38% <0.00%> (+<0.01%) ⬆️
integration-tests 37.31% <62.50%> (+0.05%) ⬆️
linux 68.79% <12.50%> (+0.05%) ⬆️
linux-nightly 70.72% <62.50%> (+0.07%) ⬆️
macos 52.38% <0.00%> (+0.05%) ⬆️
pytests 1.60% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.39% <0.00%> (+<0.01%) ⬆️
unittests 65.70% <0.00%> (+0.05%) ⬆️
upgradability 0.29% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyan-gupta
Copy link
Contributor Author

shreyan-gupta commented Apr 30, 2024

Note: Do not merge till we deploy and check partial witness on forknet

@shreyan-gupta shreyan-gupta added this pull request to the merge queue May 24, 2024
Merged via the queue into master with commit a8ff1d2 May 24, 2024
27 of 29 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/stateless_validation/remove_csw_msg branch May 24, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants