[Tracing] Skeleton for alternative opentelemetry collector. #11092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11092 +/- ##
==========================================
- Coverage 71.10% 71.10% -0.01%
==========================================
Files 763 766 +3
Lines 153166 153153 -13
Branches 153166 153153 -13
==========================================
- Hits 108906 108893 -13
+ Misses 39828 39826 -2
- Partials 4432 4434 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tayfunelmas
reviewed
Apr 18, 2024
|
|
||
| pub struct Collector {} | ||
|
|
||
| impl Collector { |
There was a problem hiding this comment.
can you add some comment about context, eg. how/where this will be used?
tayfunelmas
approved these changes
Apr 18, 2024
nagisa
reviewed
Apr 22, 2024
| @@ -0,0 +1,20 @@ | |||
| [package] | |||
| name = "near-tracing" | |||
There was a problem hiding this comment.
We already got o11y, is there a good reason to introduce a separate crate if o11y would end up depending on this anyway?
(not that it matters much either way...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can function as an alternative collector that neard can send tracing spans to. It works. We just need to figure out how to store this data next.