Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): for hashes #294

Merged
merged 5 commits into from
May 30, 2024
Merged

feat(schema): for hashes #294

merged 5 commits into from
May 30, 2024

Conversation

dzmitry-lahoda
Copy link
Contributor

for #293

@dzmitry-lahoda
Copy link
Contributor Author

dzmitry-lahoda commented May 15, 2024

does not seem any of failed CI issues relates to my code, locally cargo test was success

@dzmitry-lahoda
Copy link
Contributor Author

@frol @dj8yfo may you help me?

error: unnecessary use of `get(param).is_some()`
   --> borsh-derive/src/internals/generics.rs:159:45
    |
159 |             if associated_type_params_usage.get(param).is_some() && !params_set.contains(param) {
    |                                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(param)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
    = note: `-D clippy::unnecessary-get-then-check` implied by `-D clippy::all`
    = help: to override `-D clippy::all` add `#[allow(clippy::unnecessary_get_then_check)]`

seems something with CI as my PR has no relation to this code

@dzmitry-lahoda
Copy link
Contributor Author

dzmitry-lahoda commented May 24, 2024

change is also backward compatible with S = RandomState

@dj8yfo dj8yfo merged commit cdb8fa9 into near:master May 30, 2024
3 of 7 checks passed
@frol frol mentioned this pull request May 30, 2024
This was referenced May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants