Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MT token: approval management, add owner_id to the mt_is_approved params #421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MT token: approval management, add owner_id to the mt_is_approved params #421

wants to merge 2 commits into from

Conversation

uncle-T0ny
Copy link

No description provided.

@uncle-T0ny uncle-T0ny requested a review from a team as a code owner October 27, 2022 17:56
@uncle-T0ny uncle-T0ny marked this pull request as draft October 27, 2022 17:57
@uncle-T0ny uncle-T0ny mentioned this pull request Oct 28, 2022
Open
@ori-near ori-near added the S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. label Dec 5, 2022
@ori-near
Copy link
Contributor

ori-near commented Dec 5, 2022

Hi @uncle-T0ny – thank you for starting this proposal. As the moderator, I labeled this PR as "Needs author revision" because it appears like you are still working on it.

Please ping the @near/nep-moderators once you are ready for us to review it. We will review it again in early January, unless we hear from you sooner. We typically close NEPs that are inactive for more than two months, so please let us know if you need more time.

@ori-near ori-near added A-NEP-Extension A new functionality proposal to existing NEP. Once original author merges changes, we close this. WG-contract-standards Contract Standards Work Group should be accountable labels Dec 5, 2022
@uncle-T0ny
Copy link
Author

Hi @ori-near, yes, I need more time, because I have more proposals to improve the standard. Currently, I'm working on them. Thanks.

@uncle-T0ny uncle-T0ny changed the title MT toke: approval management, add owner_id to the mt_is_approved params MT token: approval management, add owner_id to the mt_is_approved params Jan 24, 2023
@uncle-T0ny uncle-T0ny marked this pull request as ready for review January 27, 2023 17:45
@uncle-T0ny
Copy link
Author

@near/nep-moderators
This is a small fix, I think other improvements to the standard should be on different PRs.

@frol
Copy link
Collaborator

frol commented Jan 27, 2023

@uncle-T0ny good catch! I wonder how to proceed with this. I feel we should take down the MT standard from the nomicon and get them back to the NEPs (neps folder), and only actually merge MT NEPs after we have a contract implementation that is tested by several parties to ensure that errors like this do not show up.

Would you be open to helping here? Specifically, turn this nomicon page into a NEP (neps/nep-0421.md), and let's review the whole MT approval management NEP properly (the original submission was rushed and since that time it seems that no real-world implementations appeared as otherwise, they would uncover this cruel missing piece)

@victorchimakanu
Copy link

Hello everyone, I'd like to understand the current status of this NEP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-NEP-Extension A new functionality proposal to existing NEP. Once original author merges changes, we close this. S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. WG-contract-standards Contract Standards Work Group should be accountable
Projects
NEPs
Status: DRAFT
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uncle-T0ny @ori-near @frol @victorchimakanu