Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(standards): get rid of confusing tokens folder #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

telezhnaya
Copy link
Contributor

Some points why I'm against this grouping:

  • For me, it looks like all the standards should be about tokens, we don't have other examples now;
  • FT and NFT both have token inside, but they are too different to put them into one category;
  • We've made the decision in Enhanced API to use the word Coin for FTs and native balance, and Token here could be confusing for the users.

@telezhnaya telezhnaya requested a review from frol October 25, 2022 11:13
@telezhnaya telezhnaya requested a review from a team as a code owner October 25, 2022 11:13
@render
Copy link

render bot commented Oct 25, 2022

@telezhnaya
Copy link
Contributor Author

I re-checked the links, and they look good. I guess the checker takes the links from master
If you know someone responsible for CI in this project, please ping them

@frol frol added documentation Improvements or additions to documentation WG-contract-standards Contract Standards Work Group should be accountable labels Oct 25, 2022
@frol
Copy link
Collaborator

frol commented Oct 25, 2022

@telezhnaya Thanks for bringing it up here, and proposing a change that we can review. I feel we need a better structure there. "Tokens" section reflects the common implementation detail, but it does include the native NEAR token here, so it is indeed a bad taxonomy here. Yet, flattening it up to the "Standards" level is also not productive (though, it is not a. blocker)

We will also need to figure out how to configure redirects for the old links as there are way too many of them already shared in various documentation articles, StackOverflow answers, etc. I believe this is actually a huge blocker for this PR to land.

@ori-near We will need some help here from someone who can help organize the setup, so we can easily configure redirects from the old links to the new place

@frol frol added S-review/needs-sme-review A NEP in the REVIEW stage is waiting for Subject Matter Expert review. A-Nomicon-Changes An update to the Nomicon documentation. and removed documentation Improvements or additions to documentation labels Dec 20, 2022
@ori-near ori-near added S-review/needs-wg-to-assign-sme A NEP that needs working group to assign two SMEs. and removed S-review/needs-sme-review A NEP in the REVIEW stage is waiting for Subject Matter Expert review. labels Jan 23, 2023
@ori-near
Copy link
Contributor

Thank you @telezhnaya for submitting this Nomicon change. As a moderator, I am moving it to the REVIEW stage and would like to ask the @near/wg-contract-standards working group members to assign 1 Technical Reviewer to complete a review (see expectations). If you want to assign yourself, please mention that you are acting as the Technical Reviewer.

Please find some guidelines below for completing the technical review.

Technical Review Guidelines
  • First, review the proposal within one week. If you have any suggestions that could be fixed, leave them as comments to the author. It may take a couple of iterations to resolve any open comments.
  • Second, once all the suggestions are addressed, produce:
    • A recommendation for the working group for the next step (approve and merge the PR OR reject and close the PR)

Please tag the @near/wg-contract-standards working group once you are done, so they can merge or close the PR. Thanks again.

@ori-near
Copy link
Contributor

As a moderator, we are waiting for the Contract Standards Work Group to have more capacity to review this NEP. We will pause it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Nomicon-Changes An update to the Nomicon documentation. S-review/needs-wg-to-assign-sme A NEP that needs working group to assign two SMEs. WG-contract-standards Contract Standards Work Group should be accountable
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

None yet

3 participants