commitlint: subject-full-stop integration tests #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the responsibility of the plugins to deal with rawStr in any way they want/need, not the caller of the plugin.
Strictly speaking, there's one test that is checking that one of the commitlint's native rules works (not a plugin of ours).
This rule was most of the time not working for us before, because of an upstream bug[1] which we have now fixed [2]. Given that a recent commit[3] upgraded our version of commitlint, we can just add integration tests now and we are done. [1] conventional-changelog/commitlint#3530 [2] conventional-changelog/commitlint#3531 [3] 1975174 Co-authored-by: Zahra TehraniNasab <zahratehraninasab@gmail.com>
knocte
force-pushed
the
wip/testEndingDotInTitle
branch
from
20e4038
to
677a973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule was most of the time not working for us before, because of an upstream bug which we have now fixed. Given that a recent commit upgraded our version of commitlint, we can just add integration tests now and we are done.
Supersedes #8