FileConventions: fix WrapText function #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add failing test for WrapText function based on [1]. [1] nblockchain#117
parhamsaremi
force-pushed
the
issue-117
branch
from
5a924f9
to
1fa1684
Compare
|
@parhamsaremi my review is the following: Sometimes we cut corners to get something to work, do some hack here and there. You didn't do this with this code, it seems. However, you went to the other extreme: you overengineered. Look at the diff, it's too complicated for such a simple thing that should just skip wrapping code blocks. You can write much much simpler code by having a loop that goes over all lines, and as soon as it finds three ticks and an EOL, stop wrapping text, and as soon as it finds it again, resume the text wrapping operation. For such a simple algorithm, you don't need regular expressions at all. |
parhamsaremi
force-pushed
the
issue-117
branch
5 times, most recently
from
f3486b8
to
0e1b393
Compare
knocte
reviewed
Aug 16, 2023
knocte
reviewed
Aug 16, 2023
|
@aarani please review |
parhamsaremi
force-pushed
the
issue-117
branch
2 times, most recently
from
a69af6f
to
fe739b6
Compare
Ignore codeblocks while splitting the text into paragraphs because there might be a codeblock with multiple paragraphs. Fixes nblockchain#117
parhamsaremi
force-pushed
the
issue-117
branch
from
fe739b6
to
fc2c4d5
Compare
|
@aarani good now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore codeblocks while splitting the text into paragraphs because there might be a codeblock with multiple paragraphs.
Fixes #117