New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite magic handler #595
Conversation
c5afe09
to
1e3fba9
Compare
Did a bunch of integration tests, and this still passes. This results in less regular expressions, though it does mean giving up on processing Python code within magics, such as %timeit foo = bar() However, it does mean being able to handle
so IMO it's worth it EDIT doesn't handle the latter case in the end. However, it is a lot simpler, much faster, and easier to maintain, so IMO this is still worth it |
Need to update the known limitations, improve some naming, and improve efficiency of the ast parsing (store a nested dict where the first layer just has the line number) |
@MarcoGorelli You could merge this PR. I am unable to review it currently |
closes #594