fikser bug der variabel i søknads-api-tekstene ikke ble erstattet #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siljee
previously approved these changes
Feb 22, 2021
siljee
reviewed
Feb 22, 2021
| export const replaceNavkontor = (text: string, valgtEnhetsNavn?: string) => { | ||
| // Hvis ikke valgtEnhetsNavn finnes, erstattes søkestrengen med capture-gruppa ([\w\s-]*) | ||
| // som er 1 eller fler bokstaver, whitespace eller '-', feks "NAV-kontoret ditt" fra søknads-api-tekstene | ||
| return text.replaceAll(/{navkontor:([\w\s-]*)}/g, valgtEnhetsNavn ? valgtEnhetsNavn : "$1"); |
There was a problem hiding this comment.
.replaceAll er tydeligvis ikke en funksjon 🤔
Fungerer denne i alle nettlesere?
There was a problem hiding this comment.
Byttet til replace! Trodde først det ikke funket, men nå ser det ut som det funket likevel. Skal test i labs for sikkerhetsskyld, må bare få bygget igjennom først :)
(ble litt tidlig PR, hadde tenkt å lage draft, men fikk det ikke til i ettertid..)
|
Bygg feiler, sies at det skulle ha kommet en fix på sikkerhetshullet i helgen facebook/create-react-app#10412, så ser an litt. |
|
Kudos, SonarCloud Quality Gate passed!
|
mrbjoern
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.