Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sts: resttemplate -> webclient #336

Merged
merged 16 commits into from
Mar 16, 2021
Merged

sts: resttemplate -> webclient #336

merged 16 commits into from
Mar 16, 2021

Conversation

martintveter
Copy link
Contributor

No description provided.

@martintveter martintveter marked this pull request as ready for review March 16, 2021 07:58
@martintveter martintveter requested a review from a team as a code owner March 16, 2021 07:58
Base automatically changed from test_reactive_spring to master March 16, 2021 08:30
linemos
linemos previously approved these changes Mar 16, 2021
@siljee
Copy link
Contributor

siljee commented Mar 16, 2021

Er ikke denne endringen avhengig av

    val httpClient: HttpClient = HttpClient.create()
        .proxy { proxy ->
            proxy.type(ProxyProvider.Proxy.HTTP).host(uri.host).port(uri.port)
        }

i https://github.com/navikt/sosialhjelp-innsyn-api/pull/337/files ?

@martintveter
Copy link
Contributor Author

martintveter commented Mar 16, 2021

Er ikke denne endringen avhengig av

    val httpClient: HttpClient = HttpClient.create()
        .proxy { proxy ->
            proxy.type(ProxyProvider.Proxy.HTTP).host(uri.host).port(uri.port)
        }

i https://github.com/navikt/sosialhjelp-innsyn-api/pull/337/files ?

Stemmer det.. endret på det i #337

@siljee
Copy link
Contributor

siljee commented Mar 16, 2021

Nei, @martintveter . Jeg tar det tilbake.
Det er bare viktig når man kaller ting utenfor NAV :)

@martintveter
Copy link
Contributor Author

Er ikke denne endringen avhengig av

    val httpClient: HttpClient = HttpClient.create()
        .proxy { proxy ->
            proxy.type(ProxyProvider.Proxy.HTTP).host(uri.host).port(uri.port)
        }

i https://github.com/navikt/sosialhjelp-innsyn-api/pull/337/files ?

Tar heller inn #337 først, så kan jeg fikse merge i denne etterpå

@siljee
Copy link
Contributor

siljee commented Mar 16, 2021

Er ikke denne endringen avhengig av

    val httpClient: HttpClient = HttpClient.create()
        .proxy { proxy ->
            proxy.type(ProxyProvider.Proxy.HTTP).host(uri.host).port(uri.port)
        }

i https://github.com/navikt/sosialhjelp-innsyn-api/pull/337/files ?

Tar heller inn #337 først, så kan jeg fikse merge i denne etterpå

Men stsClient burde ikke trenge proxy da den er innenfor NAV :)

@nais-deploy nais-deploy bot temporarily deployed to dev-sbs:teamdigisos March 16, 2021 09:47 Inactive
@martintveter martintveter merged commit d84b73e into master Mar 16, 2021
@martintveter martintveter deleted the feature/sts_webclient branch March 16, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants