Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): Support dual CJS/ESM package #2241

Merged
merged 2 commits into from Aug 9, 2021

Conversation

netil
Copy link
Member

@netil netil commented Aug 9, 2021

Issue

#2202

Details

  • add type:”module” to package.json
  • Support for CJS/ESM by conditional exports
  • for CJS, will consume packaged with d3.js to solve compatibility issue
  • ESM build will distributed from ‘dist-esm’ (before dist/*.esm.js)

@netil netil added the feature label Aug 9, 2021
@netil netil self-assigned this Aug 9, 2021
- add `type:”module”` to package.json
- Support for CJS/ESM by conditional exports
- for CJS, will consume packaged with d3.js to solve compatibility issue
- ESM build will distributed from ‘dist-esm’ (before dist/*.esm.js)

Ref naver#2202
@netil netil force-pushed the dual-module#2202 branch 2 times, most recently from a7f3f6f to 4c0b488 Compare August 9, 2021 07:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.186% when pulling 78abf74 on netil:dual-module#2202 into 313c7c8 on naver:master.

@netil
Copy link
Member Author

netil commented Aug 9, 2021

Module not found: Error: caused on test run.

It works fine with webpack v5.48.0, but it fails with v5.49.0.

@netil netil merged commit 437c007 into naver:master Aug 9, 2021
@netil netil deleted the dual-module#2202 branch September 8, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants