Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to sort SecretsProvider class objects in plugin config features registry #1065

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Don't try to sort SecretsProvider class objects in plugin config features registry #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
facc568
Fix TypeError when trying to sort `SecretsProvider` class objects
jathanism Nov 10, 2021
a9b0bb8
Don't sort `secrets_providers` when added to features.
jathanism Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion nautobot/extras/plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def ready(self):
if secrets_providers is not None:
for secrets_provider in secrets_providers:
register_secrets_provider(secrets_provider)
self.features["secrets_providers"] = sorted(secrets_providers)
self.features["secrets_providers"] = secrets_providers

@classmethod
def validate(cls, user_config, nautobot_version):
Expand Down
3 changes: 3 additions & 0 deletions nautobot/extras/secrets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
class SecretsProvider(ABC):
"""Abstract base class for concrete providers of secret retrieval features."""

def __repr__(self):
return f"<{self.name}>"

@abstractproperty
def slug(self):
"""String uniquely identifying this class; will be used as a key to look up the class owning a given Secret."""
Expand Down