Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Kubernetes Authentication Method #35

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Adding Kubernetes Authentication Method #35

merged 9 commits into from
Jul 27, 2022

Conversation

nniehoff
Copy link
Contributor

This PR addresses the k8s portion of #34.

@nniehoff
Copy link
Contributor Author

I ran into some pylint issues so I refactored get_value_for_secret into an additional 2 functions get_client and validate_vault_settings.

@nniehoff
Copy link
Contributor Author

Let me know what you think of this PR, AWS should be equally simple and I have some code somewhere I should be able to use.

@nniehoff nniehoff mentioned this pull request Jul 19, 2022
Closed
@nniehoff nniehoff requested a review from jathanism July 20, 2022 00:24
jathanism
jathanism approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef's kiss 💋

@nniehoff nniehoff mentioned this pull request Jul 21, 2022
Merged
@glennmatthews glennmatthews merged commit 42bb03c into nautobot:develop Jul 27, 2022
@glennmatthews glennmatthews mentioned this pull request Jul 27, 2022
Closed
@glennmatthews glennmatthews linked an issue Jul 28, 2022 that may be closed by this pull request
Support a setting to disable certificate verification #32
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathanism jathanism jathanism approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

@jedelman8 jedelman8 Awaiting requested review from jedelman8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support a setting to disable certificate verification
3 participants
@nniehoff @jathanism @glennmatthews