Experiment: Gist brew storage #3351
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides paths for creating, updating, and deleting Gist storage backing for homebrewery when enable_gists has been added to the config file. This currently is set to use a hard coded token - a dynamic token from the user's account or app auth will still need to be added.
dbolack-ab
added
feature
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic github gist-backed brew storage.
Code for creation, loading, and deletion are present. At this time, a hardcoded Github token is required ( the empty testToken variable at the top of /server/homebrew.api.js ) until a decision is made on how it is preferred to acquire and/or store the user token.
This is in relation to #3350
In order to complete this per team preferences, github login needs to be added to natural crit before adjustments can be made to this code.