Enable User Brew theme selection #3321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been implemented three different ways to allow for comparison and discussion - /api/css/:id : This returns the style frontmatter of the referenced document as a text/css document. /api/theme/:id : This returns an object with the reference'd object's theme and style frontmatter. /api/csstheme/:id : This returns the stylye frontmatter of the referenced document as a text/css document and adds the theme as an @import ( if not using the legacy renderer )
This adds a comment/field ( depending on endpoint ) that reports the name of the Brew being used as a theming source.
This consolidates the style/theme endpoint to a singular method, adds interpretation of static themes, and allow parent theme recursion. I am not 100% sure this will order styles correctly.
This updates the theme picker to include brews tagged as themes owned by the user. Some supporting functions were updated. User themes are loaded on /edit and added to the request.
|
Test theme: https://homebrewery.naturalcrit.com/share/qr7i-TXHV8yf |
|
A theme from a brew with If you could in this PR, make sure legacy renderer brews are ignored completely, that would be nice. |
…mebrewery into brew_themes_user_selection
Can't provide example right now as the whole system seems to be failing. |
This adds the User Brew themes, where applicible, to the /new path. This adds a semi-graceful failure to the metadata panel when a Brew Theme is declared as used but is not present. More gracefully handles loading with themes not present.
For User/Brew Themes, display the first author instead of Brew/V3 in the first column.
Add 5e-Cleric's suggestsions to acvoid the title overflowing over the preview.
Open
|
What do we need to bring this one to the end? |
|
I still want to give this one a deep review for code quality but if the functionality is working it should be mostly ready. This will be next on the stack when I get #3261 merged which should be soon. |
5e-Cleric
reviewed
May 29, 2024
5e-Cleric
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the UI elements to the metadata selector for users to select brews tagged as
themeorThemeas a brew's theme.It also swaps in use of the CSS endpoints ( with small changes ) from #3303