Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Archive page (search published brews) #3263

Open
wants to merge 129 commits into
base: master
Choose a base branch
from

Conversation

5e-Cleric
Copy link
Member

@5e-Cleric 5e-Cleric commented Jan 22, 2024

This is just me trying to create the most wanted function, find published brews by title.

This PR creates a new Page, with name to be determined, temporary name is Archive page, it also creates a new API endpoint to get files based of title, with multiple additional filters.

As per last update, has 2 separate request that are run simultaneously in first load of query, then only one of them is run with every reload. This avoids timeouts.

Added files and their functions:

  • archivePage.jsx
  • archivePage.less
  • archive.api.js

Modified files:

  • homebrew.jsx: added Route for the page
  • brewItem.jsx: modified author display to show 'no authors';
  • app.js:

There is no nav link to the page just yet. Go to https://homebrewery-pr-3263.herokuapp.com/archive

Changes

For a next PR

  • Turn to functional component
  • Use $search or $facet methods
  • Use splitPane component
  • Use listPage component

ToDo in this PR

  • Change Page size to page count (name)
  • Page count from input to select
  • Disable button programatically
  • Fix CSS for background not filling the page correctly
  • unable selection

@5e-Cleric 5e-Cleric mentioned this pull request Jan 22, 2024
@5e-Cleric 5e-Cleric changed the title Admin page tinkering Admin fix & Archive page (search published brews) Jan 22, 2024
@5e-Cleric 5e-Cleric added the Epic label Jan 22, 2024
@5e-Cleric 5e-Cleric self-assigned this Jan 22, 2024
@5e-Cleric 5e-Cleric linked an issue Jan 22, 2024 that may be closed by this pull request
@5e-Cleric 5e-Cleric changed the title Admin fix & Archive page (search published brews) [FEATURE]: Archive page (search published brews) Jan 23, 2024
@5e-Cleric
Copy link
Member Author

5e-Cleric commented Jan 23, 2024

toDo list:

  • move from admin.api to its own
  • use listpage.jsx and brewitem.jsx
  • add filtering functions
    • renderer
    • cloned or not
    • excluding words?
    • views?
    • authors?
    • theme
  • implement agnostic UI
  • response brew count
  • page size query option

@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 06:21 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 06:22 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 06:24 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 06:52 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 10:27 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 10:29 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 10:33 Inactive
@5e-Cleric 5e-Cleric added 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging and removed 🔍 R4 - Reviewed - Fixed! ⭐ PR review comments addressed labels May 22, 2024
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 17:49 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 17:55 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 22, 2024 18:11 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 23, 2024 11:32 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 23, 2024 11:35 Inactive
@5e-Cleric 5e-Cleric temporarily deployed to homebrewery-pr-3263 May 23, 2024 11:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic 🔍 R3 - Reviewed - Awaiting Fixes 🔧 PR is okayed but needs fixes before merging
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

Published Brews
5 participants