standalone verify function #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
standalone-verify-function
branch
from
6c4bc62
to
eb1067a
Compare
The 'verify' class method of KeyPair is more typically used in the context where the signing key is not known. For this reason, the 'verify' method is now a standalone function which takes an verifying (public) nkey, and the class method (of the same name) calls the standalone function. Additionally, since it is no longer guaranteed thatt the nkey will be well-formed, validation is performed.
JaredCorduan
force-pushed
the
standalone-verify-function
branch
from
eb1067a
to
5deb8d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello! I hope you don't mind unsolicited PRs. :)
I found myself wanting to use the
verifyclass method ofKeyPairin the typical context where the signing key is not known. And it was simple enough to move the function out of the class (and allow the class method of the same name to call the standalone one).Additionally, since it is no longer guaranteed that the nkey will be well-formed, validation is performed.
The existing tests cover the new standalone function without any changes.