Benchmark should not panic on server close #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
force-pushed
the
benchmark-dont-panic-on-server-close
branch
from
3b8d39f
to
0e17d5b
Compare
Jarema
reviewed
May 17, 2023
| nc.publish("bench".to_string(), msg.clone().into()) | ||
| .await | ||
| .unwrap(); | ||
| let result = |
There was a problem hiding this comment.
Maybe better directly check for disconnect event on the client and the break the loop, log publish errors (but not panic)?
The benchmark results and report would be cleaner about what happened.
There was a problem hiding this comment.
So about printing the error, I don't want to give the impression that the benchmark failed when its expected (albeit racy behavior).
Could instead just loop from 0 to N and still unwrap.
There was a problem hiding this comment.
I get your point and agree with it.
I'm talking about maybe having more graceful and controlled shutdown of server/clients in benchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.