Improve reconnect randomization #868
Open
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/improve-reconnect-randomization
branch
from
1c65c0b
to
a721429
Compare
caspervonb
reviewed
Mar 8, 2023
| @@ -99,8 +101,13 @@ impl Connector { | |||
|
|
|||
| pub(crate) async fn try_connect(&mut self) -> Result<(ServerInfo, Connection), io::Error> { | |||
| let mut error = None; | |||
| let server_addrs = { | |||
| let mut rng = thread_rng(); | |||
There was a problem hiding this comment.
This is already mut, so connector could own the rng without issue.
Suggested change
| let mut rng = thread_rng(); | |
| let mut rng = thread_rng(); |
There was a problem hiding this comment.
Not sure.
Connector needs to be Send.
Do we prefer to just call it at try_connect or put it behind Arc?
I think the former.
Jarema
force-pushed
the
jarema/improve-reconnect-randomization
branch
from
a721429
to
f432fa4
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
caspervonb
force-pushed
the
jarema/improve-reconnect-randomization
branch
from
f432fa4
to
bcf5ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.