Fix jetstream PagedIterator infinite loop #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaizensparc are you still interested in this PR? |
|
Hello, |
On current nats server version (2.8) when a paged request is made to jetstream (e.g. to list the stream names), the page will never be empty, making the last page being repeated over and over and hanging if calling collect() on it. This fix implements the same fix as jsm.go(5a418c) manager.go +236 by stopping when detecting it's the last page.
Jarema
force-pushed
the
fix-nats-paged-iterator
branch
from
ad08e2a
to
f6d144e
Compare
Jarema
requested changes
Jan 2, 2023
| @@ -539,6 +539,10 @@ where | |||
| return None; | |||
| } | |||
|
|
|||
| if page.total <= page.limit + page.offset { | |||
There was a problem hiding this comment.
We should check for:
if page.items.len() + page.offset >= page.total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On current nats server version (2.8) when a paged request is made to jetstream (e.g. to list the stream names), the page will never be empty, making the last page being repeated over and over and hanging if callingcollect() on it.
This fix implements the same fix as jsm.go(5a418c) manager.go +236 by stopping when detecting it's the last page.