Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reconnect_buffer_size builder fn #1249

Closed
wants to merge 1 commit into from

Conversation

WamboOSX
Copy link

This adds the missing builder function for reconnect_buffer_size in ConnectOptions.

Was there any reason why it was not added until now?

@paolobarbolini
Copy link
Contributor

Is this another dead variable like the one I've encountered the other day? 😅
https://github.com/search?q=repo%3Anats-io%2Fnats.rs%20reconnect_buffer_size&type=code

@Jarema
Copy link
Member

Jarema commented Apr 12, 2024

Yes, this option is not used. Was carried over from the sync client. The mechanism in async are different.

To control the amount of messges buffered, use client_capacity() option.

@Jarema
Copy link
Member

Jarema commented May 20, 2024

The dead code has been removed. Closing.
Sorry for the confusion.

@Jarema Jarema closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants