Implement Deserialize trait for ServerAddress #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nepalez
force-pushed
the
main
branch
3 times, most recently
from
9a9c9c9
to
fc43063
Compare
|
I'm not sure about this, as there are a lot of types that are serialized with try_from/from_str via serde itself. @Jarema wdyt? |
nepalez
force-pushed
the
main
branch
2 times, most recently
from
8b4bfec
to
f6c1f29
Compare
See: nats-io#717 Impement the serde deserializer for the ServerAddress(Url) struct based on the existing implementation of `from_str`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #717
Impement the serde deserializer for the ServerAddress(Url) struct based on the existing implementation of
from_str.