Make use of into_future for requests and messages
#1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
changed the title
into_future for Client and Context
caspervonb
changed the title
into_future for requests and messages
n1ghtmare
force-pushed
the
n1ghtmare/into-future-refactor
branch
2 times, most recently
from
f419f65
to
8c109bc
Compare
4 tasks
n1ghtmare
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
8c109bc
to
21e6620
Compare
caspervonb
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
21e6620
to
06e8c7d
Compare
n1ghtmare
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
06e8c7d
to
3d613b3
Compare
n1ghtmare
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
8e0663b
to
d7dbf6d
Compare
Jarema
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
d7dbf6d
to
78243d1
Compare
| @@ -1268,6 +1195,106 @@ impl Publish { | |||
| } | |||
| } | |||
|
|
|||
| impl IntoFuture for Publish { | |||
| type Output = Result<PublishAckFuture, PublishError>; | |||
| type IntoFuture = Pin<Box<dyn Future<Output = Result<PublishAckFuture, PublishError>> + Send>>; | |||
There was a problem hiding this comment.
Why not use BoxFuture from futures here?
|
|
||
| impl IntoFuture for Publish { | ||
| type Output = Result<(), PublishError>; | ||
| type IntoFuture = Pin<Box<dyn Future<Output = Result<(), PublishError>> + Send>>; |
There was a problem hiding this comment.
Also BoxFuture here
n1ghtmare
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
2498525
to
285222f
Compare
Co-authored-by: Casper Beyer <caspervonb@pm.me>
Co-authored-by: Casper Beyer <caspervonb@pm.me>
Co-authored-by: Casper Beyer <caspervonb@pm.me>
Co-authored-by: Casper Beyer <caspervonb@pm.me>
Jarema
force-pushed
the
n1ghtmare/into-future-refactor
branch
from
285222f
to
bfd34f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #782