Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to handle 409 Leadership Changed errors in client #1151

Merged
merged 2 commits into from Dec 3, 2022
Merged

Provide a way to handle 409 Leadership Changed errors in client #1151

merged 2 commits into from Dec 3, 2022

Commits on Dec 2, 2022

  1. Provide a way to handle 409 Leadership Changed errors in client 

    Without this change, it makes it hard for clients to handle consumer
errors relating to leadership changes differently from any other
error.

Follows same approach as ErrConsumerDeleted.
    @sata-form3
    sata-form3 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    a52a9ec View commit details
    Browse the repository at this point in the history

  2. PR Review feedback 

    PR Review feedback over [slack](https://form3.slack.com/archives/C02281GJCJF/p1669986912679049).

Currently there are already users who are performing error string
comparision for this use case. To avoid introducing a breaking change
until there is a better way of handling these error messages, we will
retain the error message for the newly introduced canonical error
value.
    @sata-form3
    sata-form3 committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b2ad744 View commit details
    Browse the repository at this point in the history