[FEAT] [EXPERIMENTAL] direct get of messages for KV #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FEAT] [KV] experimental - KvOptions can now specify `allow_direct` which enables the creation of streams on servers that supported that enable the direct api which may provide better performance on gets for KV. [FIX] internal checkJsErrorCode() was passing a status instead of a description, creating error descriptions prefixed by the error code
|
The matching server pull |
piotrpio
reviewed
Jun 2, 2022
| @@ -89,7 +89,7 @@ export function checkJsError(msg: Msg): NatsError | null { | |||
| if (!h) { | |||
| return null; | |||
| } | |||
| return checkJsErrorCode(h.code, h.status); | |||
| return checkJsErrorCode(h.code, h.description); | |||
There was a problem hiding this comment.
We want to check description vs status?
There was a problem hiding this comment.
the status line contains the code/message - the description is just the message part of that combo, so it uglified some of the errors.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_directwhich enables the creation of streams on servers that supported that enable the direct api which may provide better performance on gets for KV.