Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typed stream update #230

Merged
merged 1 commit into from Nov 29, 2021
Merged

typed stream update #230

merged 1 commit into from Nov 29, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 29, 2021

this creates a breaking change - for API symmetry with update consumer, the name of the stream is now a required argument.

@aricart
typed stream update - this creates a breaking change - for api symm…
25cf542 
…etry with update consumer, the name of the stream is now a required argument.
@aricart
Copy link
Member Author

aricart commented Nov 29, 2021

@kozlovic the change for the consumer is here:

#229

kozlovic
kozlovic approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit fdec4e2 into main Nov 29, 2021
@aricart aricart deleted the stream-update branch November 29, 2021 20:47
This was referenced Jan 19, 2022
Closed
Merged
This was referenced Feb 2, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Mar 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

@ripienaar ripienaar Awaiting requested review from ripienaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aricart @kozlovic