Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed format of JSClusterNoPeers error #3459

Merged
merged 5 commits into from
Sep 9, 2022
Merged

changed format of JSClusterNoPeers error #3459

merged 5 commits into from
Sep 9, 2022

Commits on Sep 8, 2022

  1. changed format of JSClusterNoPeers error 

    This error was introduced in #3342 and reveals to much information
This change gets rid of cluster names and peer counts.

All other counts where changed to booleans,
which are only included in the output when the filter was hit.

In addition, the set of not matching tags is included.

Signed-off-by: Matthias Hanel <mh@synadia.com>
    @matthiashanel
    matthiashanel committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    94dbd8e View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. staticcheck fixes 

    Signed-off-by: Matthias Hanel <mh@synadia.com>
    @matthiashanel
    matthiashanel committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    028c71e View commit details
    Browse the repository at this point in the history

  2. Remove "peer selection failures: " from the error 

    Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    367844f View commit details
    Browse the repository at this point in the history

  3. moving error description into Error 

    samples:
1) no suitable peers for placement, tags not matched ['cloud:GCP', 'country:US']"
2) no suitable peers for placement, insufficient storage

Signed-off-by: Matthias Hanel <mh@synadia.com>
    @matthiashanel
    matthiashanel committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    f7759fd View commit details
    Browse the repository at this point in the history

  4. fix unit test 

    Signed-off-by: Matthias Hanel <mh@synadia.com>
    @matthiashanel
    matthiashanel committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    83c7b37 View commit details
    Browse the repository at this point in the history