Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run npm audit fix #20

Merged
merged 2 commits into from
May 7, 2019
Merged

Run npm audit fix #20

merged 2 commits into from
May 7, 2019

Conversation

gtvj
Copy link
Contributor

@gtvj gtvj commented May 3, 2019

We've been notified of a security issue related to a dependency (of a dependency) of node-sass that we're using in this project. See screenshot below:

Screenshot 2019-05-03 at 17 07 50

I tried to fix this with npm audit fix but it seems it's going to need a fix from the package developers (See description in this discussion: sass/node-sass#2625)

This is being discussed broadly (incl. on the cross-govt developer channels) and it seems affected repos should be OK server-side (as this one is).

We'll keep an eye on it and update as soon as a fix is available.

Changes to package-lock.json and package.json result from this
command.
@karlkern karlkern merged commit 9acdcbe into develop May 7, 2019
@karlkern karlkern deleted the feature/fix_security_issue branch May 7, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants