Upgrade jest to latest version #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot Jest upgrade PR cause all tests to fail Manually do upgrade with fix for Jest tests: - 'ts-jest' version required upgrade: kulshekhar/ts-jest#2612 (comment) - Add 'testEnvironment' to Jest config: https://stackoverflow.com/questions/67373953/jest-fails-with-self-is-not-defined-when-importing-react-diagrams
…ives/tdr-transfer-frontend into manual-upgrade-jest
suzannehamilton
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
This looks good to me. I normally want to run either the JS or Scala tests, but not both, so running them together got in the way more than it helped.
Could you let all the devs know once this is merged, though? Just in case it catches people out because they were relying on sbt test running the npm tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot Jest upgrade PR cause all tests to fail
Manually do upgrade with fix for Jest tests: