Implement method override check without instanceof #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support making assertions against elements that exist within another iframe, we cannot use `instanceof` to check if we should override the Assertion method. This fails because `window.HTMLElement !== otherWindow.HTMLElement`. Instead use the `nodeType` property to check if we're dealing with an element, or for the `NodeList` check use the class name.
|
Thanks! I like this implementation. Did you test this with |
|
I haven't actually - just with Chrome, Firefox and PhantomJS - any suggestions for testing with |
|
I did a manual sanity test and it looks fine. I should add another test target or such for |
|
👍 awesome, thank you for being so responsive! |
|
No problem! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #8:
In order to support making assertions against elements that exist within
another iframe, we cannot use
instanceofto check if we shouldoverride the Assertion method. This fails because
window.HTMLElement !== otherWindow.HTMLElement. Instead use thenodeTypeproperty tocheck if we're dealing with an element, or for the
NodeListcheck usethe class name.